>>
>>>> 14328 object names in conditions are case sensitive
>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=14328
>>> this is a great catch! One quick question - did you test with
>>> qualified ncu name conditions (e.g. "link:bge0 is online",
>>> "interface:bge0 is online")as well as unqualified?
>>> The reason I ask is I'm pretty sure nwam_ncu_read() will accept
>>> a qualified name as an arg, but not 100%. Thanks!
>> yes, works with both qualified and unqualified ncu names.
>>
>>        
>> http://zhadum.east.sun.com/export/ws/am223141/temp/nwam1-work/webrev/
>>
>> I also changed test_condition_domain() so that a case-insensitive 
>> comparisons are done for domain names.  I am not able to unlint lint 
>> 252, so I added the /* LINTED */.
>>
>> I believe ESSIDs are case-sensitive, so I did not change the strcmp() 
>> for those.
>>
>>
> makes sense. The changes look good, but one
> thing I couldn't figure out is why you need the
> LINTED tag for line 252 but not line 257.
That I don't know.  When I added one for line 257, lint complained

"conditions.c", line 257: warning: lint suppression directive not used 
(E_SUPPRESSION_DIRECTIVE_UNUSED)

Anurag

Reply via email to