>>>>>> 14328 object names in conditions are case sensitive >>>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=14328 >>>>> this is a great catch! One quick question - did you test with >>>>> qualified ncu name conditions (e.g. "link:bge0 is online", >>>>> "interface:bge0 is online")as well as unqualified? >>>>> The reason I ask is I'm pretty sure nwam_ncu_read() will accept >>>>> a qualified name as an arg, but not 100%. Thanks! >>>> yes, works with both qualified and unqualified ncu names. >>>> >>>> >>>> http://zhadum.east.sun.com/export/ws/am223141/temp/nwam1-work/webrev/ >>>> >>>> I also changed test_condition_domain() so that a case-insensitive >>>> comparisons are done for domain names. I am not able to unlint >>>> lint 252, so I added the /* LINTED */. >>> makes sense. The changes look good, but one >>> thing I couldn't figure out is why you need the >>> LINTED tag for line 252 but not line 257. >> That I don't know. When I added one for line 257, lint complained >> >> "conditions.c", line 257: warning: lint suppression directive not >> used (E_SUPPRESSION_DIRECTIVE_UNUSED) >> > would #include'ing <ctype.h> (without any LINTED > tags) help maybe? Not something that should hold up > your push, but might be worth a try... yes, that was it. I missed that #include. I also alphabetized the #includes.
Anurag
