On Mon, Feb 08, 2010 at 04:07:23PM -0800, Renee Danson Sommerfeld wrote:
> On Mon, Feb 08, 2010 at 03:54:57PM -0800, Michael Hunter wrote:
> > On Mon, 08 Feb 2010 11:23:37 -0800
> > Renee Danson Sommerfeld <renee.sommerfeld at sun.com> wrote:
> > 
> > > On Mon, Feb 08, 2010 at 07:15:48AM -0800, Michael Hunter wrote:
> > > > For these bugs found during zones testing:
> > > > 
> > > > 14302 -  netcfgd needs refresh specified to reduce log noise
> > > > 14305 -  netcfgd/nwamd have issues starting up in a zone
> > > > 14311 -  svcs -xv output dated
> > > > 14423 -  pfail() outputs trash
> > > > 14424 -  /lib/svc/method/net-nwam shouldn't set UMEM_DEBUG
> > > > 14425 -  error message for fattach in nwam_door_init() is busted
> > > > 
> > > > /net/coupe.eng/builds/mph/nwam1_bug/webrev
> > > 
> > > nwamd/util.c: when we're dropping unneeded privileges, why don't we
> > >   need to change the effective set?  That's what we give everything
> > >   to when we escalate, seems like it would need to change when we
> > >   de-escalate.
> > 
> > ACCEPT
> 
> But now the effective set is set to allpriv_set; shouldn't that be
> priv_set?  Is that just a typo?

Also, I don't think your change to the pfail call on line 267 should
be there, the original text was correct (permitted vs. effective in
the string).

-renee

> > > Regarding the doc links: the hub.opensolaris.org links are every bit
> > > as stable as the opensolaris.org links you just ripped out.  :-)
> > > The main project page link *should* redirect, I thought; but it isn't
> > > working for me now.
> > 
> > ACCEPT
> 
> network-physical.xml does not appear to have been changed in your latest
> webrev (i.e. it still shows the two opensolaris.org references removed,
> but the hub.opensolaris.org link hasn't been added).
> 
> -renee
> _______________________________________________
> nwam-dev mailing list
> nwam-dev at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/nwam-dev

Reply via email to