On Mon, Feb 08, 2010 at 04:12:37PM -0800, Renee Danson Sommerfeld wrote: > On Mon, Feb 08, 2010 at 04:07:23PM -0800, Renee Danson Sommerfeld wrote: > > On Mon, Feb 08, 2010 at 03:54:57PM -0800, Michael Hunter wrote: > > > On Mon, 08 Feb 2010 11:23:37 -0800 > > > Renee Danson Sommerfeld <renee.sommerfeld at sun.com> wrote: > > > > > > > nwamd/util.c: when we're dropping unneeded privileges, why don't we > > > > need to change the effective set? That's what we give everything > > > > to when we escalate, seems like it would need to change when we > > > > de-escalate. > > > > > > ACCEPT > > > > But now the effective set is set to allpriv_set; shouldn't that be > > priv_set? Is that just a typo? > > Also, I don't think your change to the pfail call on line 267 should > be there, the original text was correct (permitted vs. effective in > the string). > > > > > Regarding the doc links: the hub.opensolaris.org links are every bit > > > > as stable as the opensolaris.org links you just ripped out. :-) > > > > The main project page link *should* redirect, I thought; but it isn't > > > > working for me now. > > > > > > ACCEPT > > > > network-physical.xml does not appear to have been changed in your latest > > webrev (i.e. it still shows the two opensolaris.org references removed, > > but the hub.opensolaris.org link hasn't been added).
Okay, your latest webrev takes care of all of this. Looks good! -renee
