I submitted a new PR that deals with the merge conflicts left in the branch. I haven't been able to verify the fix yet as I'm having some issues with setting up the preview processor on my machine.
Cheers - Bert On 8 Aug 2012, at 21:38, Erik Froese <erik.fro...@gmail.com> wrote: > Thanks > > On Wed, Aug 8, 2012 at 3:38 PM, Bert Pareyn <pareyn.b...@gmail.com> wrote: >> I can look into the PR tomorrow to see what still needs to be done. >> If Arno is happy to continue the task outside of his internship that'd be >> great, otherwise I'll reassign. >> >> Regards, >> - Bert >> >> On 8 Aug 2012, at 19:08, Erik Froese <erik.fro...@gmail.com> wrote: >> >>> Bert? Arno? >>> >>> Can you weigh in here? I found this unmerged PR >>> https://github.com/sakaiproject/3akai-ux/pull/2099 >>> >>> Also I started documenting how to run the Java PP here: >>> https://confluence.sakaiproject.org/display/KERNDOC/Using+the+Java+Preview+Processor >>> >>> Erik >>> >>> >>> On Tue, Aug 7, 2012 at 6:18 PM, Erik Froese <erik.fro...@gmail.com> wrote: >>>> Actually I'd take a PNG export over a PDF any day. Then all the PP has >>>> to do is fetch the PNG, resize it, and we're done. >>>> >>>> In the interest of landing this work and not getting hung up on stuff >>>> that hasn't been sorted out yet, let's please limit this thread to the >>>> existing intended functionality. Content thumbnails for sakai docs. >>>> >>>> Erik >>>> >>>> On Tue, Aug 7, 2012 at 5:56 PM, Simon Gaeremynck <gaeremyn...@gmail.com> >>>> wrote: >>>>> The impl for making sakaidocs indexable relies on phantomjs as there >>>>> seems to be no option to get the parsed HTML out of wkhtmltopdf (correct >>>>> me if I'm wrong though!) PhantomJS has an option to export to PDF but >>>>> it's not nearly as good as wkhtmltopdf. It does have a good PNG export >>>>> mechanism but that's obviously not what we want here. >>>>> >>>>> It's a bit of a shame we need two separate tools for this. It would've >>>>> been much better to just use wkhtmltopdf for both of them. >>>>> >>>>> Simon >>>>> >>>>> >>>>> On 7 Aug 2012, at 22:46, Nate Angell <nang...@rsmart.com> wrote: >>>>> >>>>>> So this seems like part of the intersection between the conversations on >>>>>> improving the Preview Processor and the conversation on making sakaidocs >>>>>> indexable by google (and/or other) bots. >>>>>> >>>>>> = nate >>>>>> >>>>>> On Tue, Aug 7, 2012 at 2:07 PM, Erik Froese <erik.fro...@gmail.com> >>>>>> wrote: >>>>>> Hey everyone, >>>>>> >>>>>> I'm hoping the folks who did the implementation for previewing sakai >>>>>> documents with wkhtmltopdf can help me out here. >>>>>> >>>>>> I'm seeing a few issues getting sakai doc previews to work in >>>>>> 1.5.0-SNAPSHOT. >>>>>> >>>>>> 1. Sakai documents are never marked sakai:needsprocessing = true. >>>>>> This isn't a huge deal as I can mark them by hand for testing. >>>>>> >>>>>> 2. The ruby PP expects the wkhtmltopdf binary to be in the nakamura >>>>>> tree. This is extra work for deployers. >>>>>> The Java PP searches the PATH environment variable for wkhtmltopdf and >>>>>> disables sakai doc processing if it can't find it. >>>>>> >>>>>> 3. The ruby PP only works with wkhtmltopdf version 0.9.9. I can't get >>>>>> anything but the static build of 0.9.9 to work. >>>>>> Is there any plan to move to a more recent version? Has anyone tried? >>>>>> >>>>>> 4. Once the PDF is generated the new PDF is posted to >>>>>> http://192.168.1.6:8080/p/CONTENT_ID/CONTENT_ID.processed.pdf >>>>>> I don't see that as being marked for processing either. What's the >>>>>> expected path to get this processed into thumbnails? >>>>>> Do those thumbnails get attached to the content item like the other >>>>>> items? >>>>>> >>>>>> Erik >>>>>> _______________________________________________ >>>>>> oae-dev mailing list >>>>>> oae-dev@collab.sakaiproject.org >>>>>> http://collab.sakaiproject.org/mailman/listinfo/oae-dev >>>>>> >>>>> >>> _______________________________________________ >>> oae-dev mailing list >>> oae-dev@collab.sakaiproject.org >>> http://collab.sakaiproject.org/mailman/listinfo/oae-dev > _______________________________________________ > oae-dev mailing list > oae-dev@collab.sakaiproject.org > http://collab.sakaiproject.org/mailman/listinfo/oae-dev
_______________________________________________ oae-dev mailing list oae-dev@collab.sakaiproject.org http://collab.sakaiproject.org/mailman/listinfo/oae-dev
