[ https://issues.apache.org/jira/browse/OAK-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290153#comment-13290153 ]
Julian Reschke commented on OAK-16: ----------------------------------- {quote}in addition there are still some value related tck test failing. some of those may be caused by missing validation either on oak-jcr or on oak-core... i need to take a closer look at this again.{quote} Indeed; {{SetValueFormatExceptionTest}} has many failures because nobody checks the type when overwriting the value. The test case asks for an immediate failure, so I don't think it's sufficient to handle that in a commit hook; where should the check happen? oak-jcr or oak-core? > Proper ValueFactory implementation and Value handling > ----------------------------------------------------- > > Key: OAK-16 > URL: https://issues.apache.org/jira/browse/OAK-16 > Project: Jackrabbit Oak > Issue Type: Bug > Components: jcr > Reporter: angela > Assignee: angela > Fix For: 0.3 > > > the GlobalContext contains the following code: > put(ValueFactory.class, new SimpleValueFactory()); > that doesn't work as the ValueFactory needs to be bound to each session > instance > in order to be able to deal with namespace mappings, paths, names etc.... > michi, just told me that in addition the ValueConverted needs some focus as > well. > and yesterday, i saw that Property#getType implementation in the > jackrabbit-mikrokernel > was not correct... > just to mention a few issues.... -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira