[ 
https://issues.apache.org/jira/browse/OAK-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421347#comment-13421347
 ] 

Michael Dürig commented on OAK-202:
-----------------------------------

I was catching up with what was going on while I was away fixing minor things 
as I went along. As we manage the code base collaboratively, I think it is 
preferable to have such changes in explicit commits instead of hiding them 
alongside other stuff as I often observe. This way it is easy for others to 
undo things they don't like which is much less annoying than to untangle such 
changes from "real" changes. 
                
> Simplify the code when possible
> -------------------------------
>
>                 Key: OAK-202
>                 URL: https://issues.apache.org/jira/browse/OAK-202
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: Thomas Mueller
>            Priority: Minor
>
> Sometimes it's possible to simplify the code, for example: 
> - making methods static when possible, so a reader knows the method doesn't 
> change the state of an object 
> - the "else" is unnecessary if the "if" block always returns

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to