Re: svn commit: r1562341 - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/EventGenerator.java oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/observation/EventQueue.java

[Jukka Zitting]

Hi,

On Wed, Jan 29, 2014 at 4:49 AM, Michael Dürig <mdue...@apache.org> wrote:
> On 29.1.14 2:46 , ju...@apache.org wrote:
>>           if (!continuations.isEmpty()) {
>> -            continuations.removeFirst().run();
>> +            Continuation c = continuations.removeFirst();
>> +            c.after.compareAgainstBaseState(c.before, c);
>>           }
>
> I preferred the former variant as it resembled more explicitly the notation
> of a continuation: the rest of the computation.

Agreed. The reduction in implemented interfaces that I was going for
indeed doesn't seem to justify the break in encapsulation.

I restored the run() method in r1562457, along with some related javadoc.

BR,

Jukka Zitting