Joscorbe commented on code in PR #1543:
URL: https://github.com/apache/jackrabbit-oak/pull/1543#discussion_r1650867475
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -240,7 +240,21 @@ static FullGCMode getFullGcMode() {
AUDIT_LOG.info("<init> VersionGarbageCollector created with fullGcMode
= {}", fullGcMode);
}
- public void setStatisticsProvider(StatisticsProvider provider) {
+ /**
+ * Please note that at the moment the includes do not
+ * take long paths into account. That is, if a long path was
+ * supposed to be included via an include, it is not.
+ * Reason for this is that long paths would require
+ * the mongo query to include a '_path' condition - which disallows
+ * mongo from using the '_modified_id' index. IOW long paths
+ * would result in full scans - which results in bad performance.
+ */
+ void setFullGCPaths(@NotNull Set<String> includes, @NotNull Set<String>
excludes) {
+ this.fullGCIncludePaths = requireNonNull(includes);
+ this.fullGCExcludePaths = requireNonNull(excludes);
+ }
+
+ void setStatisticsProvider(StatisticsProvider provider) {
Review Comment:
Oh, the public was lost here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
