nit0906 commented on code in PR #1577:
URL: https://github.com/apache/jackrabbit-oak/pull/1577#discussion_r1675055875
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/tree/TreeStore.java:
##########
@@ -166,4 +171,28 @@ public Store getStore() {
return store;
}
+ @Override
+ public String getStorePath() {
+ return directory.getAbsolutePath();
+ }
+
+ @Override
+ public long getEntryCount() {
+ return entryCount;
+ }
+
+ public void setEntryCount(long entryCount) {
+ this.entryCount = entryCount;
+ }
+
+ @Override
+ public String getIndexStoreType() {
+ return STORE_TYPE;
+ }
+
+ @Override
+ public boolean isIncremental() {
+ return true;
Review Comment:
This should be false.
The TreeStore should be the base implementation - that builds the a tree
representation of the whole repository, and then we can have something like an
IncrementalTreeStore, which builds the diff b/w 2 checkpoints to be appended to
the base TreeStore.
Or maybe simply use the diff by IncrementalFlatFileStore and merge that in
the base TreeStore.
Refer -
IndexStore -> FlatFileStore -> IncrementalFlatFileStore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
