mbaedke commented on code in PR #1365:
URL: https://github.com/apache/jackrabbit-oak/pull/1365#discussion_r1832875311


##########
oak-solr-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/solr/osgi/OakSolrConfigurationProviderService.java:
##########
@@ -135,25 +176,25 @@ public class OakSolrConfigurationProviderService 
implements OakSolrConfiguration
     private OakSolrConfiguration oakSolrConfiguration;
 
     @Activate
-    protected void activate(ComponentContext componentContext) throws 
Exception {
-        pathChildrenFieldName = 
String.valueOf(componentContext.getProperties().get(PATH_CHILDREN_FIELD));
-        pathParentFieldName = 
String.valueOf(componentContext.getProperties().get(PATH_PARENT_FIELD));
-        pathExactFieldName = 
String.valueOf(componentContext.getProperties().get(PATH_EXACT_FIELD));
-        collapsedPathField= 
String.valueOf(componentContext.getProperties().get(COLLAPSED_PATH_FIELD));
-        pathDescendantsFieldName = 
String.valueOf(componentContext.getProperties().get(PATH_DESCENDANTS_FIELD));
-        catchAllField = 
String.valueOf(componentContext.getProperties().get(CATCH_ALL_FIELD));
-        depthField = 
String.valueOf(componentContext.getProperties().get(PATH_DEPTH_FIELD));
-        rows = 
Integer.parseInt(String.valueOf(componentContext.getProperties().get(ROWS)));
-        commitPolicy = 
OakSolrConfiguration.CommitPolicy.valueOf(String.valueOf(componentContext.getProperties().get(COMMIT_POLICY)));
-        useForPathRestrictions = 
Boolean.valueOf(String.valueOf(componentContext.getProperties().get(PATH_RESTRICTIONS)));
-        useForPropertyRestrictions = 
Boolean.valueOf(String.valueOf(componentContext.getProperties().get(PROPERTY_RESTRICTIONS)));
-        useForPrimaryTypes = 
Boolean.valueOf(String.valueOf(componentContext.getProperties().get(PRIMARY_TYPES_RESTRICTIONS)));
-        typeMappings = 
PropertiesUtil.toStringArray(componentContext.getProperties().get(TYPE_MAPPINGS));
-        ignoredProperties = 
PropertiesUtil.toStringArray(componentContext.getProperties().get(IGNORED_PROPERTIES));
-        usedProperties = 
PropertiesUtil.toStringArray(componentContext.getProperties().get(USED_PROPERTIES));
-        propertyMappings = 
PropertiesUtil.toStringArray(componentContext.getProperties().get(PROPERTY_MAPPINGS));
-        collapseJcrContentNodes = 
Boolean.valueOf(String.valueOf(componentContext.getProperties().get(COLLAPSE_JCR_CONTENT_NODES)));
-        collapseJcrContentParents = 
Boolean.valueOf(String.valueOf(componentContext.getProperties().get(COLLAPSE_JCR_CONTENT_PARENTS)));
+    protected void activate(Configuration configuration) {
+        pathChildrenFieldName = configuration.path_child_field();

Review Comment:
   Imho hat would need a new Jira issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to