smiroslav commented on code in PR #1748:
URL: https://github.com/apache/jackrabbit-oak/pull/1748#discussion_r1840753430
##########
oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentArchiveWriterTest.java:
##########
@@ -52,29 +55,28 @@ public class AzureSegmentArchiveWriterTest {
public static final int MAX_ATTEMPTS = 3;
@Rule
- public MockServerRule mockServerRule = new MockServerRule(this);
+ public MockServerRule mockServerRule = new MockServerRule(this, 1090);
@SuppressWarnings("unused")
private MockServerClient mockServerClient;
- private CloudBlobContainer container;
+ @ClassRule
+ public static AzuriteDockerRule azurite = new AzuriteDockerRule();
@Before
public void setUp() throws Exception {
- container = createCloudBlobContainer();
-
+ mockServerClient = new MockServerClient("localhost",
mockServerRule.getPort());
System.setProperty("azure.segment.archive.writer.retries.intervalMs",
"100");
System.setProperty("azure.segment.archive.writer.retries.max",
Integer.toString(MAX_ATTEMPTS));
// Disable Azure SDK own retry mechanism used by
AzureSegmentArchiveWriter
- System.setProperty("segment.azure.retry.attempts", "0");
+ System.setProperty("segment.azure.retry.backoff", "1");
Review Comment:
where is ```segment.azure.retry.backoff``` defined?
##########
oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/MockAzureHttpResponse.java:
##########
@@ -0,0 +1,62 @@
+package org.apache.jackrabbit.oak.segment.azure;
Review Comment:
The license header is missing
##########
oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentArchiveWriterTest.java:
##########
@@ -86,15 +88,17 @@ public void
retryWhenFailureOnWriteBinaryReferences_eventuallySucceed() throws E
.when(writeBinaryReferencesRequest, Times.once())
.respond(response().withStatusCode(201));
+ SegmentArchiveWriter writer = createSegmentArchiveWriter();
Review Comment:
Why those lines have to be moved here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
