kwin commented on code in PR #1993:
URL: https://github.com/apache/jackrabbit-oak/pull/1993#discussion_r1938329073
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/namepath/impl/GlobalNameMapper.java:
##########
@@ -67,10 +67,15 @@ protected static boolean isHiddenName(String name) {
protected static boolean isExpandedName(String name) {
if (name.startsWith("{")) {
int brace = name.indexOf('}', 1);
- return brace != -1 && name.substring(1, brace).indexOf(':') != -1;
- } else {
- return false;
+ if (brace != -1) {
+ String namespace = name.substring(1, brace);
+ // the empty namespace is valid as well, otherwise it always
contains a colon (as it is a URI)
Review Comment:
Done in https://issues.apache.org/jira/browse/OAK-11450, yes seems test
coverage is not complete here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
