reschke commented on code in PR #2093: URL: https://github.com/apache/jackrabbit-oak/pull/2093#discussion_r1960989563
########## oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/SessionImpl.java: ########## @@ -845,6 +846,12 @@ public UserManager getUserManager() throws RepositoryException { return sessionContext.getUserManager(); } + @Override + @NotNull + public Set<Principal> getPrincipals() throws RepositoryException { + return sd.getAuthInfo().getPrincipals(); + } Review Comment: We may want to check for consistency with other APIs. Maybe Iterable would be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org