rishabhdaim commented on code in PR #2146:
URL: https://github.com/apache/jackrabbit-oak/pull/2146#discussion_r1984789466
##########
oak-store-spi/src/main/java/org/apache/jackrabbit/oak/plugins/memory/PropertyStates.java:
##########
@@ -89,7 +90,7 @@ public static PropertyState createProperty(
String name, Iterable<Value> values)
throws RepositoryException {
int type = PropertyType.STRING;
- Value first = Iterables.getFirst(values, null);
+ Value first = StreamUtils.toStream(values).findFirst().orElse(null);
Review Comment:
>Benchmark (size) Mode Cnt Score Error Units
IterableUtils.apache 1 avgt 4 0.001 ± 0.001 us/op
IterableUtils.apache 100 avgt 4 0.001 ± 0.001 us/op
IterableUtils.apache 10000 avgt 4 0.001 ± 0.001 us/op
IterableUtils.apache 1000000 avgt 4 0.001 ± 0.001 us/op
IterableUtils.guava 1 avgt 4 0.001 ± 0.001 us/op
IterableUtils.guava 100 avgt 4 0.001 ± 0.001 us/op
IterableUtils.guava 10000 avgt 4 0.001 ± 0.001 us/op
IterableUtils.guava 1000000 avgt 4 0.001 ± 0.001 us/op
IterableUtils.stream 1 avgt 4 0.007 ± 0.002 us/op
IterableUtils.stream 100 avgt 4 0.007 ± 0.001 us/op
IterableUtils.stream 10000 avgt 4 0.007 ± 0.001 us/op
IterableUtils.stream 1000000 avgt 4 0.007 ± 0.001 us/op
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
