bhabegger commented on code in PR #2902:
URL: https://github.com/apache/jackrabbit-oak/pull/2902#discussion_r3248039206
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/tree/TreeStoreNodeState.java:
##########
@@ -201,7 +205,15 @@ private void fetch() {
if (index < 0) {
throw new IllegalArgumentException(key);
}
- current = key.substring(index + 1);
+ if (!key.startsWith(path + "\t")) {
Review Comment:
If I understand correctly this is a stop condition because we've reached the
sibling following the current node ? So `treeStore.getSession().iterator(path)`
returns all the paths starting a `path` depth first ? So the method should
really be named `getDescendantNodeNamesIterator(String path)`, or do I miss
understand something ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
