reschke commented on code in PR #2729:
URL: https://github.com/apache/jackrabbit-oak/pull/2729#discussion_r3332686117
##########
oak-blob-cloud-azure/pom.xml:
##########
@@ -285,7 +285,6 @@
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
Review Comment:
That's intended. The other version is embedded.
##########
oak-segment-azure/pom.xml:
##########
@@ -181,29 +181,24 @@
<dependency>
<groupId>org.codehaus.woodstox</groupId>
<artifactId>stax2-api</artifactId>
- <version>4.2.2</version>
</dependency>
Review Comment:
are they used in other modules? are some of these embedded?
##########
oak-segment-azure/pom.xml:
##########
@@ -326,16 +310,14 @@
</dependency>
- <!-- Azure Guava dependency -->
+ <!-- Azure Guava dependency - version managed in parent POM -->
Review Comment:
intended
##########
oak-parent/pom.xml:
##########
@@ -750,13 +828,7 @@
<artifactId>httpmime</artifactId>
<version>4.5.14</version>
</dependency>
- <!-- Testcontainers dependency -->
- <dependency>
- <groupId>org.testcontainers</groupId>
- <artifactId>testcontainers</artifactId>
- <version>${testcontainers.version}</version>
- <scope>test</scope>
- </dependency>
+
Review Comment:
Moving dependencies around - in particular many at once makes it extremely
had to trak changes. See also
https://jackrabbit.apache.org/oak/docs/participating.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
