bhabegger commented on PR #2729:
URL: https://github.com/apache/jackrabbit-oak/pull/2729#issuecomment-4648909328
As per request in the JIRA here is the result of before/after versions
pulled in for artifacts that ahve embedded dependencies:
# Embedded dependencies: before vs. after `rationalize-dependencies`
Branch: `rationalize-dependencies` vs. `apache/trunk`
## Key findings
- The `Embed-Dependency` instruction lists are **identical in every module**
— no artifacts are added or removed.
- The branch moves version declarations from individual module POMs into
`oak-parent/pom.xml` for a subset of cases, but all **resolved versions are
identical**.
- Modules not touched by the branch (`oak-blob-cloud-azure`,
`oak-blob-cloud`, `oak-segment-tar`, `oak-auth-ldap`, `oak-segment-remote`,
`oak-segment-aws`, `oak-shaded-guava`) show the same before and after.
---
## oak-segment-azure
Embed-Dependency list: **unchanged**.
| Embedded artifact | Version before (trunk) | Version after (branch) |
|---|---|---|
| azure-storage | no local pin → parent | no local pin → parent |
| azure-keyvault-core | no local pin → parent | no local pin → parent |
| azure-core | no local pin → parent | no local pin → parent |
| azure-identity | no local pin → parent | no local pin → parent |
| azure-json | no local pin → parent | no local pin → parent |
| azure-xml | `1.0.0` in module | `1.0.0` in parent |
| azure-storage-blob | `12.25.3` in module | `12.25.3` in parent |
| azure-storage-common | `12.24.3` in module | `12.24.3` in parent |
| azure-storage-internal-avro | `12.10.3` in module | `12.10.3` in parent |
| jackson-dataformat-xml | no local pin → parent | no local pin → parent |
| guava | `33.1.0-jre` in module | `33.1.0-jre` in module (kept) |
| jsr305 | `3.0.2` in module | `3.0.2` in parent |
| reactive-streams | no local pin → parent | no local pin → parent |
| msal4j | no local pin → parent | no local pin → parent |
| reactor-core | no local pin → parent | no local pin → parent |
| oauth2-oidc-sdk | no local pin → parent | no local pin → parent |
| azure-core-http-netty | no local pin → parent | no local pin → parent |
| netty-* | `${netty.version}` in module | `${netty.version}` in parent |
| reactor-netty-http | no local pin → parent | no local pin → parent |
| reactor-netty-core | no local pin → parent | no local pin → parent |
| json-smart | no local pin → parent | no local pin → parent |
| content-type | no local pin → parent | no local pin → parent |
| accessors-smart | no local pin → parent | no local pin → parent |
| nimbus-jose-jwt | no local pin → parent | no local pin → parent |
| stax2-api | `4.2.2` in module | `4.2.2` in parent |
---
## oak-blob-cloud-azure
Embed-Dependency list: **unchanged**. No diff vs trunk — module not touched
by the branch.
| Embedded artifact | Version before (trunk) | Version after (branch) |
|---|---|---|
| azure-storage | no local pin → parent | no local pin → parent |
| azure-keyvault-core | no local pin → parent | no local pin → parent |
| azure-core | no local pin → parent | no local pin → parent |
| azure-identity | no local pin → parent | no local pin → parent |
| azure-json | no local pin → parent | no local pin → parent |
| guava | `33.1.0-jre` in module | `33.1.0-jre` in module |
| jsr305 | `3.0.2` in module | `3.0.2` in module |
| reactive-streams | no local pin → parent | no local pin → parent |
| msal4j | no local pin → parent | no local pin → parent |
| reactor-core | no local pin → parent | no local pin → parent |
| oauth2-oidc-sdk | no local pin → parent | no local pin → parent |
| azure-core-http-netty | no local pin → parent | no local pin → parent |
| netty-* | `${netty.version}` in module | `${netty.version}` in module |
| reactor-netty-http | no local pin → parent | no local pin → parent |
| reactor-netty-core | no local pin → parent | no local pin → parent |
| json-smart | no local pin → parent | no local pin → parent |
| content-type | no local pin → parent | no local pin → parent |
| accessors-smart | no local pin → parent | no local pin → parent |
| nimbus-jose-jwt | no local pin → parent | no local pin → parent |
---
## oak-blob-cloud
Embed-Dependency list: **unchanged**. No diff vs trunk.
| Embedded artifact | Version before (trunk) | Version after (branch) |
|---|---|---|
| s3 + all AWS SDK v2 core modules | `${aws.sdk.version}` in module |
`${aws.sdk.version}` in module |
| eventstream | `1.0.1` in module | `1.0.1` in module |
| reactive-streams | `1.0.4` in module | `1.0.4` in module |
| netty-* (explicit list) | `${netty.version}` in module |
`${netty.version}` in module |
---
## oak-segment-tar
Embed-Dependency list: **unchanged**. No diff vs trunk.
| Embedded artifact | Version before (trunk) | Version after (branch) |
|---|---|---|
| netty-* (wildcard) | `${netty.version}` in module | `${netty.version}` in
module |
| concurrentlinkedhashmap-lru | no local pin → parent | no local pin →
parent |
---
## oak-lucene
Embed-Dependency list: **unchanged**. Versions are governed by the
`<dependency>` version in the module POM (artifacts are embedded with
`inline=true`).
| Embedded artifact | Version before (trunk) | Version after (branch) |
|---|---|---|
| lucene-* (all, inlined) | `${lucene.version}` in module |
`${lucene.version}` in module |
| oak-search (inlined) | `${project.version}` | `${project.version}` |
| oak-core-spi (specific classes inlined) | `${project.version}` |
`${project.version}` |
---
## oak-auth-ldap
Embed-Dependency list: **unchanged**. No diff vs trunk.
| Embedded artifact | Version before (trunk) | Version after (branch) |
|---|---|---|
| api-all | `2.0.1` in module | `2.0.1` in module |
| commons-pool2 | `2.12.0` in module | `2.12.0` in module |
| mina-core | `2.1.12` in module | `2.1.12` in module |
| org.apache.servicemix.bundles.antlr | `2.7.7_5` in module | `2.7.7_5` in
module |
---
## oak-segment-remote
Embed-Dependency list: **unchanged**. No diff vs trunk.
| Embedded artifact | Version before (trunk) | Version after (branch) |
|---|---|---|
| org.apache.servicemix.bundles.* (wildcard) | `3.3.0_1` / `3.1_1` in module
| `3.3.0_1` / `3.1_1` in module |
| commons-pool2 | `2.12.0` in module | `2.12.0` in module |
---
## oak-segment-aws
Embed-Dependency list: **unchanged**. No diff vs trunk.
| Embedded artifact | Version before (trunk) | Version after (branch) |
|---|---|---|
| aws-java-sdk-s3 | `${aws.version}` = `1.12.791` in module |
`${aws.version}` = `1.12.791` in module |
| aws-java-sdk-dynamodb | `${aws.version}` = `1.12.791` in module |
`${aws.version}` = `1.12.791` in module |
| dynamodb-lock-client | `1.1.0` in module | `1.1.0` in module |
---
## oak-store-document
Embed-Dependency list: **unchanged**.
| Embedded artifact | Version before (trunk) | Version after (branch) |
|---|---|---|
| quartz (2 classes inlined: CronExpression, ValueSet) | `2.3.2` in module |
`2.3.2` in parent |
---
## oak-search-elastic
Embed-Dependency list: **unchanged** (`*;scope=compile|runtime` with
`Embed-Transitive=true`).
No version changes for any compile/runtime dependency.
| Embedded artifact | Version before (trunk) | Version after (branch) |
|---|---|---|
| oak-search (inlined) | `${project.version}` | `${project.version}` |
| elasticsearch-java | no local pin → parent | no local pin → parent |
| all compile/runtime deps (transitive) | resolved from parent/module |
resolved from parent/module (unchanged) |
---
## oak-shaded-guava
Shade list: **unchanged**. No diff vs trunk.
| Shaded artifact | Version before (trunk) | Version after (branch) |
|---|---|---|
| guava (relocated to `org.apache.jackrabbit.guava.*`) |
`${shaded.guava.version}` = `33.5.0-jre` in module | `${shaded.guava.version}`
= `33.5.0-jre` in module |
| failureaccess | no local pin → parent | no local pin → parent |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
