bhabegger commented on code in PR #2938:
URL: https://github.com/apache/jackrabbit-oak/pull/2938#discussion_r3379615557
##########
oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/editor/FulltextIndexEditor.java:
##########
@@ -158,6 +164,19 @@ public void leave(NodeState before, NodeState after)
}
}
+ if (wasIndexable && !isIndexable()) {
Review Comment:
Normally, here, we are working at commit level not at individual change
level.
So, if, in the code a mixin type was added to node A and then A was removed.
We would not see the first operation as the `after` NodeState would be null. So
we should be fine.
However, your proposal could make the code easier to read ;) So, let me see
if we can adjust that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
