seropian commented on PR #2989: URL: https://github.com/apache/jackrabbit-oak/pull/2989#issuecomment-5285632634
Thanks for the thorough review, @amit-jain! Both concerns you raised are actually already addressed in the current code: **Issue #1 (Secondary-location failover disabled when no retry config):** ✅ Fixed in `UtilsV12.createRetryOptions()` (lines 58-81). When `retries < 0 && secondaryLocation != null`, the method now builds a `RequestRetryOptions` with the SDK's default retry count (maxTries=null → 4) so the secondary host takes effect instead of being silently dropped. This mirrors the v8 behavior where secondary-location and retry config were independent. **Issue #2 (Presigned URI > 7 days with delegation keys):** ✅ Fixed via `capToDelegationKeyLifetime()` in `AzureBlobStoreBackendV12` (lines 315-325). During `initPresignedURIConfig()` (called at init time), the configured upload/download expiry is validated against `DELEGATION_KEY_LIFETIME` (7 days). If it exceeds that for service-principal auth, it's capped and a warning is logged: "Configured presigned URI expiry of Xs exceeds the Ys maximum lifetime of an Azure user delegation key; capping to Ys..." This prevents the silent misconfiguration. All three of jsedding's code-review items have also been addressed: 1. Refactored `AzureBlobContainerProviderV12` from single class with boolean into abstract base + two concrete inner classes (`ServicePrincipalProvider` / `SharedKeyProvider`) 2. Dropped env-var tier from `getUseV12Value()` (JVM property > OSGi config only; env vars injected via OSGi variable substitution) 3. Replaced `AzureDataStoreV12.setProperties()` with constructor injection Tests pass (214/214 unit tests). Ready for re-review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
