bhabegger commented on code in PR #3078:
URL: https://github.com/apache/jackrabbit-oak/pull/3078#discussion_r3812986621
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/inventory/IndexDefinitionPrinter.java:
##########
@@ -69,6 +74,17 @@ public void print(PrintWriter printWriter, Format format,
boolean isZip) {
NodeState idxState = NodeStateUtils.getNode(root, indexPath);
createSerializer(json).serialize(idxState);
}
+ // The "diff" indexes (diff.index / diff.index.optimizer) are not
oak:QueryIndexDefinition nodes, so they
+ // are not returned by the IndexPathService and would otherwise be
missing from the output. Add them
+ // explicitly, rendering their diff.json payload as inline JSON so
the pending diff is readable.
+ for (String name : new String[] {DiffIndexMerger.DIFF_INDEX,
DiffIndexMerger.DIFF_INDEX_OPTIMIZER}) {
Review Comment:
IMHO, there is a lot of *logic* for something that should be a *printer*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
