bhabegger commented on code in PR #3129:
URL: https://github.com/apache/jackrabbit-oak/pull/3129#discussion_r4035026096
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/query/SQL2Parser.java:
##########
@@ -406,11 +451,11 @@ private JoinConditionImpl parseJoinCondition() throws
ParseException {
} else {
String selector1 = name;
read(".");
- String property1 = readName();
+ String property1 = checkPropertyName(readName());
Review Comment:
Question of style: rather than requiring to put everywhere.
```
checkPropertyName(readName())
```
Why not keep the split checkPropertyName/readName but slightly different ? :
```
readNameWithCheck()
```
```
String readNameWithCheck() {
return checkPropertyName(readName())
}
```
Or even do the check inside.
(Hint: to do this I would refactor readName to readeNameWIthCheck and then
rename just the readNameWithCheck back to readName)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
