rishabhdaim commented on code in PR #3168:
URL: https://github.com/apache/jackrabbit-oak/pull/3168#discussion_r4523247171


##########
oak-segment-aws/pom.xml:
##########
@@ -33,6 +33,10 @@
     <name>Oak Segment AWS</name>
 
     <properties>
+        <skip.coverage>false</skip.coverage>

Review Comment:
   ๐ŸŸ  **P2** ยท ๐ŸŽฏ Correctness
   
   **๐Ÿ” Issue:** Both AWS test `argLine` overrides omit `${test.opts}`, so no 
`jacoco-ut.exec` is produced and the new 99% gate succeeds without checking 
coverage.
   
   **๐Ÿ› ๏ธ Fix:** Preserve the parent JVM arguments in both Surefire/Failsafe 
overrides while keeping the SQLite property:
   ```xml
   <argLine>${test.opts} -javaagent:${org.mockito:mockito-core:jar} 
-Dsqlite4java.library.path="${project.build.directory}/dependencies"</argLine>
   ```
   Then set the minimums from the resulting full-module coverage report.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to