[ 
https://issues.apache.org/jira/browse/OAK-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455750#comment-13455750
 ] 

Thomas Mueller commented on OAK-304:
------------------------------------

> -1 to adding even more words to the method name.

My idea was: the longer the name, the more careful people are to call it :-) 
Given that the method is rather expensive, that would be actually an advantage 
in this case. OK just joking.

getLatestRoot() is fine for me.

> OAK-201

Thanks. I initially created OAK-201 because of explicit Session.refresh calls 
which seem to be gone now thanks to Marcels patch. But it seems there might 
still be potential to speed things up, by not calling getCurrentRoot / 
getLatestRoot for each getPrefix or getURI.
                
> Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot()
> --------------------------------------------------------------
>
>                 Key: OAK-304
>                 URL: https://issues.apache.org/jira/browse/OAK-304
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>         Attachments: OAK-304.patch
>
>
> Renaming the method would make it clear that the method is potentially 
> expensive and the returned object reflects the head of the repository at the 
> time the method is called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to