[ 
https://issues.apache.org/jira/browse/OAK-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679383#comment-13679383
 ] 

Thomas Mueller commented on OAK-856:
------------------------------------

> Yes, but that's outside the scope of unit tests.

On the one hand, your are right: The storage implementation should have its own 
set of tests.

But on the other hand, it's nice if you can easily run _all_ existing unit 
tests with a (new) storage implementation, to find bugs in the storage. Now we 
can not easily do that, because of the missing close / dispose.

I wonder if the MongoMK should implement java.io.Closeable. That way we 
wouldn't have to change the MicroKernel API, but could still close the 
MicroKernel if it implements Closeable. That would also simplify switching to 
the LogWrapper / TimingWrapper (now, whenever I switch, I have to change at 
least 3 places, which is annoying).


                
> Use in-memory MongoMK instead of MicroKernelImpl for tests
> ----------------------------------------------------------
>
>                 Key: OAK-856
>                 URL: https://issues.apache.org/jira/browse/OAK-856
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>
> Currently, most tests are run against the (in-memory) MicroKernelImpl.
> To improve test coverage of the MongoMK, we should use the MongoMK instead by 
> default.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to