[ 
https://issues.apache.org/jira/browse/OAK-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13720772#comment-13720772
 ] 

Michael Dürig commented on OAK-932:
-----------------------------------

Looking at the patch I don't see much gain in the current refactorings. The 
only methods that both {{Root}} implementations share are {{getQueryEngine}} 
and {{getTree}}. OTOH the patch introduces more complexity through the various 
abstract {{Root}} implementations whose intend seems quite vague. 

As mentioned [on the list | http://markmail.org/message/n6gcco5arks7prsp] we 
should first clarify what problem we want to tackle here. 
                
> RootImpl to AbstractRoot
> ------------------------
>
>                 Key: OAK-932
>                 URL: https://issues.apache.org/jira/browse/OAK-932
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Antonio Sanso
>         Attachments: OAK-932-patch.txt
>
>
> as discussed in [0] it would be nice to have a common Root ancestor for 
> mutable/immutable tree similar to what already exists for the Tree
> [0] http://oak.markmail.org/thread/fe5p4dhf2i5korqy

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to