[
https://issues.apache.org/jira/browse/OAK-932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13720858#comment-13720858
]
Michael Dürig commented on OAK-932:
-----------------------------------
Thanks for the patch. A few remarks:
* The patch contains tabs. Please only use spaces for indenting.
* Isn't the todo on {{SystemRootImpl(NodeStore)}} addressed with that change
and can be removed?
* Please add some JavaDoc stating the intent of {{SystemRootImpl}}. Also
{{SystemRootImpl#getContentSession().getLatestRoot()}} method needs
clarification since it bends the original contract, which states: "The root
instance gives you a stable view of the tree at the time the root is acquired".
This might not be the case here since the implementation simply returns "the
old" root.
* Couldn't we use {{AuthInfoImpl}} instead of another anonymous inner class for
implementing {{getAuthInfo()}}?
* Finally I'd rename {{SystemRootImpl}} to {{SystemRoot}}
> RootImpl to AbstractRoot
> ------------------------
>
> Key: OAK-932
> URL: https://issues.apache.org/jira/browse/OAK-932
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Antonio Sanso
> Attachments: OAK-932a-patch.txt, OAK-932-patch.txt
>
>
> as discussed in [0] it would be nice to have a common Root ancestor for
> mutable/immutable tree similar to what already exists for the Tree
> [0] http://oak.markmail.org/thread/fe5p4dhf2i5korqy
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
