[ 
https://issues.apache.org/jira/browse/OAK-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13738261#comment-13738261
 ] 

Michael Dürig commented on OAK-659:
-----------------------------------

At revision 1513469 I committed an initial fix, which,

* still keeps transient changes from commit hooks in memory when running with a 
MicroKernel. See TODOs in {{KernelNodeState.builder()}},
* when running on SegmentMK the relevant implementations in 
{{SegmentNodeStore}} falls back to their defaults, which might not be optimal.

[~jukkaz] could you have a look at the respective TODOs in {{SegmentNodeStore}} 
when you come around to it?
                
> Move purge logic for transient changes below the NodeBuilder interface
> ----------------------------------------------------------------------
>
>                 Key: OAK-659
>                 URL: https://issues.apache.org/jira/browse/OAK-659
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Michael Dürig
>         Attachments: OAK-659-2.patch, OAK-659.patch
>
>
> Currently transient changes are purged down to a persisted branch once a 
> certain size threshold is hit. This logic currently resides in {{RootImpl}}. 
> However this approach doesn't catch the case where a lot of content is added 
> by a commit hook (e.g. index updates) since commit hooks operate on the 
> {{NodeBuilder}} level which is below {{Root}}. 
> The aim of this issue is to pursue ways to push the purge logic further down 
> below the {{NodeBuilder}} interface. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to