[ 
https://issues.apache.org/jira/browse/OAK-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740928#comment-13740928
 ] 

Michael Dürig commented on OAK-659:
-----------------------------------

Running {{RootFuzzIT}} against MongoMK and SegmentMK quickly results in errors. 
(I didn't remember earlier that {{RootFuzzIT}} only runs against the H2 
Microkernel). Trying with an older revision from before the refactoring turned 
up the same errors. In a quick chat with Jukka, we concluded that it is 
probably best to:

* revert the refactoring,
* parametrise our tests to run against all back ends and fix surfacing errors,
* reattempt the refactoring. 
                
> Move purge logic for transient changes below the NodeBuilder interface
> ----------------------------------------------------------------------
>
>                 Key: OAK-659
>                 URL: https://issues.apache.org/jira/browse/OAK-659
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Michael Dürig
>         Attachments: OAK-659-2.patch, OAK-659.patch
>
>
> Currently transient changes are purged down to a persisted branch once a 
> certain size threshold is hit. This logic currently resides in {{RootImpl}}. 
> However this approach doesn't catch the case where a lot of content is added 
> by a commit hook (e.g. index updates) since commit hooks operate on the 
> {{NodeBuilder}} level which is below {{Root}}. 
> The aim of this issue is to pursue ways to push the purge logic further down 
> below the {{NodeBuilder}} interface. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to