[
https://issues.apache.org/jira/browse/OAK-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833759#comment-13833759
]
Julian Reschke commented on OAK-928:
------------------------------------
This test now frequently fails on my machine. Details:
Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.36 sec <<<
FAILURE!
testAddNodeCollidingWithInvisibleNode(org.apache.jackrabbit.oak.security.authorization.evaluation.ShadowInvisibleContentTest)
Time elapsed: 0.09 sec <<< FAILURE!
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:92)
at org.junit.Assert.assertTrue(Assert.java:43)
at org.junit.Assert.assertTrue(Assert.java:54)
at
org.apache.jackrabbit.oak.security.authorization.evaluation.ShadowInvisibleContentTest.testAddNodeCollidingWithInvisibleNode(ShadowInvisibleContentTest.java:129)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> Read access is enforced on NEW items
> ------------------------------------
>
> Key: OAK-928
> URL: https://issues.apache.org/jira/browse/OAK-928
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: angela
> Assignee: Jukka Zitting
> Fix For: 0.13
>
>
> as explained in OAK-923 we may currently run into the situation where a new
> Tree is being added because it does not exist but the resulting child does
> not exist due to restricted access. the same is true for new properties.
> IMHO this breaks backwards compatibility with jackrabbit core.
> i would therefore suggest to
> - extend MutableTree#exists by checking for the tree being new
> line 390:
> {noformat}
> - return nodeBuilder.exists();
> + return nodeBuilder.isNew() || nodeBuilder.exists();
> {noformat}
> - similar behavior for #hasProperty #getProperty, #getProperties and
> #getPropertyCount (no patch yet).
> however, i would like to get a broader consensus on this kind of
> modifications as this
> might have side effects in other places.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
