[
https://issues.apache.org/jira/browse/OAK-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837623#comment-13837623
]
Jukka Zitting commented on OAK-1159:
------------------------------------
Great!
BTW, one stylistic issue (thus dependent on personal preferences) about the
null-check-in-finalize pattern you're using:
{code}
Closeable resource = null;
try {
resource = ...; // initialize the resource
...; // do something with the resource
} finally {
if (resource != null) {
resource.close();
}
}
{code}
In cases where the resource initialization is guaranteed to never return
{{null}} (like when using {{new}}), the pattern can be simplified to:
{code}
Closeable resource = new ...; // initialize the resource
try {
...; // do something with the resource
} finally {
resource.close();
}
{code}
Some people additionally prefer to make the variable {{final}} to prevent
anything within the {{try}} block from resetting the value.
> Backup and restore
> ------------------
>
> Key: OAK-1159
> URL: https://issues.apache.org/jira/browse/OAK-1159
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: core, mk
> Reporter: Michael Marth
> Assignee: Alex Parvulescu
> Attachments: OAK-1159-v2.patch, OAK-1159.patch
>
>
> We need a way to backup and restore a repository. I was thinking that the MK
> impl could expose an interface for this, as the actual implementation would
> differ quite a bit between e.g. TarMK and MongoMK.
> Also, I think we could leverage the MVCC nature of the MKs and mark a
> specific revision as "the revision to backup" (regardless of ongoing writes).
> That would allow us to prevent the ugly situation in JR2, that we need to
> stop writes for a while to produce a consistent backup.
> The restore in such a scenario would discard revisions that happened after
> said marker (but still made it into the backup).
--
This message was sent by Atlassian JIRA
(v6.1#6144)
