[
https://issues.apache.org/jira/browse/OAK-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878435#comment-13878435
]
angela commented on OAK-1285:
-----------------------------
patch 0002 looks similar to what i tried to do in my very first draft of the
user query... i don't recall the very details but i didn't get that work.
so, i agree that executing the user query with the local namespace mappings
would be cleaner.
having said that: the user query manager in fact 'has' the local mappings but
they are hidden in the namepathmapper. which means that we would basically have
all the information we need but we can't access them any more... instead of
inventing yet another helper interface that encapsulates namepathmapper and the
namespacemapping, wouldn't it be possible allow for building/extracting the
namespace mapping from a given NamePathMapper... e.g. via NameMapper plus
extension?
> QueryEngine#executeQuery takes NamePathMapper which is not part of oak-api
> --------------------------------------------------------------------------
>
> Key: OAK-1285
> URL: https://issues.apache.org/jira/browse/OAK-1285
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: angela
> Assignee: Jukka Zitting
> Fix For: 0.16
>
> Attachments:
> 0001-OAK-1285-QueryEngine-executeQuery-takes-NamePathMapp.patch,
> 0002-OAK-1285-QueryEngine-executeQuery-takes-NamePathMapp.patch
>
>
> [~fmeschbe] spotted the following inconsistency in the oak api:
> o.a.j.o.api.QueryEngine#executeQuery(String statement, String language,
> long limit, long offset, Map<String, ? extends PropertyValue>
> bindings,
> NamePathMapper namePathMapper) throws ParseException;
> takes a NamePathMapper which is not part of the oak api but only defined in
> the plugins.
> to resolve that inconsistency we may consider moving the NamePathMapper to a
> new o.a.j.oak.api.namepath package and keep the implementations in the
> plugins.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
