[
https://issues.apache.org/jira/browse/OAK-1285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878906#comment-13878906
]
Jukka Zitting commented on OAK-1285:
------------------------------------
Hmm, good point about getting the mappings from {{NamePathMapper}}. I didn't
think of that as I originally wanted to hide all mapping details below the
interface (you just give it a name string and it returns the result, mapped in
whichever way is appropriate), but given that we already do have the
{{hasSessionLocalMappings()}} method it seems reasonable to also add
{{getSessionLocalMappings()}}.
> QueryEngine#executeQuery takes NamePathMapper which is not part of oak-api
> --------------------------------------------------------------------------
>
> Key: OAK-1285
> URL: https://issues.apache.org/jira/browse/OAK-1285
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
> Reporter: angela
> Assignee: Jukka Zitting
> Fix For: 0.16
>
> Attachments:
> 0001-OAK-1285-QueryEngine-executeQuery-takes-NamePathMapp.patch,
> 0002-OAK-1285-QueryEngine-executeQuery-takes-NamePathMapp.patch
>
>
> [~fmeschbe] spotted the following inconsistency in the oak api:
> o.a.j.o.api.QueryEngine#executeQuery(String statement, String language,
> long limit, long offset, Map<String, ? extends PropertyValue>
> bindings,
> NamePathMapper namePathMapper) throws ParseException;
> takes a NamePathMapper which is not part of the oak api but only defined in
> the plugins.
> to resolve that inconsistency we may consider moving the NamePathMapper to a
> new o.a.j.oak.api.namepath package and keep the implementations in the
> plugins.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
