[ 
https://issues.apache.org/jira/browse/OAK-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899120#comment-13899120
 ] 

Thomas Mueller commented on OAK-377:
------------------------------------

Hm, looking at the source code of the external sort, I see 
Runtime.getRuntime().freeMemory() is used. I think it should be avoided, as the 
returned value is kind of arbitrary (could be very low if called right before a 
JVM full GC). Instead, I think a fixed memory chunk should be used, for example 
8 MB (configurable). I guess it's not urgent, but something we could report.

The rest of the patch looks good, I will try to merge it and then do some more 
review.

> Data store garbage collection
> -----------------------------
>
>                 Key: OAK-377
>                 URL: https://issues.apache.org/jira/browse/OAK-377
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, mk
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>             Fix For: 0.17
>
>         Attachments: OAK-377.patch
>
>
> Unused binaries in the data store need to be garbage collected.
> There is a partial implementation in oak-mk, however it is currently not run 
> (not run automatically, and I think there is no way to run it manually).
> Also, we might want to investigate in faster garbage collection algorithms: 
> young generation garbage collection, or garbage collection using reference 
> counting (for example using an index of references to the data store).



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to