[
https://issues.apache.org/jira/browse/OAK-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899150#comment-13899150
]
Thomas Mueller commented on OAK-377:
------------------------------------
Hi,
A few remarks, I will try to fix them myself:
ChunkIterator.hasNext ignores all exceptions. Instead, a RuntimeException
should be thrown.
ChunkIterator.next, I know this is matter of taste, but will slightly change
the code from
{noformat}
public String next() {
if (!hasNext()) {
throw new NoSuchElementException("No data");
} else {
return queue.remove();
}
}
{noformat}
to
{noformat}
public String next() {
if (!hasNext()) {
throw new NoSuchElementException("No data");
}
return queue.remove();
}
{noformat}
In Eclipse, there is a setting where the former code results in a warning
("Statement unnecessarily nested within else clause.")
There is some incorrectly formatted code, for example:
{noformat}
} finally {
conn.commit();
conn.close();
} // <=== should be more to the right
{noformat}
> Data store garbage collection
> -----------------------------
>
> Key: OAK-377
> URL: https://issues.apache.org/jira/browse/OAK-377
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, mk
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
> Fix For: 0.17
>
> Attachments: OAK-377.patch
>
>
> Unused binaries in the data store need to be garbage collected.
> There is a partial implementation in oak-mk, however it is currently not run
> (not run automatically, and I think there is no way to run it manually).
> Also, we might want to investigate in faster garbage collection algorithms:
> young generation garbage collection, or garbage collection using reference
> counting (for example using an index of references to the data store).
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
