[ 
https://issues.apache.org/jira/browse/OAK-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001494#comment-14001494
 ] 

Michael Dürig commented on OAK-1806:
------------------------------------

Thanks for the patch. Committed most of it with slight modifications at 
svn.apache.org/r1595777. This looks like a good start!

Some minor issue I would like to address:
* Your changes to {{pom.xml}} change the default activation of the profiles. I 
skipped this part of the patch for now. Could you clarify the impact of this on 
the rest {{oak-run}} first? 
* 
{{org.apache.jackrabbit.oak.scalability.ScalabilityAbstractSuite#loginWriter}} 
synchronizes on a local variable {{session}}. Is that really what you intended 
to do? Shouldn't this be {{sessions}} instead?
* {{org.apache.jackrabbit.oak.benchmark.util.Date#toISO_8601_2000}} accesses a 
{{SimpleDateFormat}} instance, which is not thread safe. Are we sure we are 
safe here?

Also could you add some Javadoc to the Interfaces and abstract base classes as 
these parts will probably be used by others. 

Please follow up with patches on this issue as necessary. 

> Benchmark for blob upload and search longevity
> ----------------------------------------------
>
>                 Key: OAK-1806
>                 URL: https://issues.apache.org/jira/browse/OAK-1806
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: run
>            Reporter: Amit Jain
>              Labels: benchmark, test
>         Attachments: OAK-1806.patch
>
>
> Have a longevity test which incrementally increases the load by adding blobs 
> and then running full text search to measure the execution times and the 
> performance degradation for increased loads.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to