[
https://issues.apache.org/jira/browse/OAK-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574124#comment-14574124
]
Amit Jain commented on OAK-2960:
--------------------------------
[~frm]
The behavior matches what we have for the DocumentNodeStoreService.
The intended behavior for @Modified annotated method is to detect changes for
the property {{blobGcMaxAgeInSecs}} only as it is safer to do it dynamically.
For the other properties I am not so sure that is the case. In fact for the
property {{customBlobStore}}, it is definitely not safer to change it midway as
switching the property would mean that the earlier blobs would not be found,
so, they are handled only on activate.
> SegmentNodeStoreService should correctly handle modifications in the
> configuration
> ----------------------------------------------------------------------------------
>
> Key: OAK-2960
> URL: https://issues.apache.org/jira/browse/OAK-2960
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segmentmk
> Reporter: Francesco Mari
> Priority: Critical
> Fix For: 1.3.0
>
> Attachments: OAK-2960-01.patch
>
>
> The {{SegmentNodeStoreService}} component recently introduced an
> {{@Modified}} method that picks up changes in just one configuration property
> and ignores the rest.
> Some configuration properties, like {{customBlobStore}}, have a huge impact
> on the dynamic behaviour of the component. If the component fails to pick up
> these changes, its behaviour is just wrong.
> The {{@Modified}} method should be removed. It is safer to go through a
> complete deactivation and activation process.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
