[
https://issues.apache.org/jira/browse/OAK-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14574140#comment-14574140
]
Amit Jain commented on OAK-2960:
--------------------------------
[~frm]
{quote}
The solution developed for OAK-2016 forces a user to unbind the configuration,
modify properties (if one of the properties to modify is not
blobGcMaxAgeInSecs), and bind the configuration again. This behaviour, other
than being cumbersome
{quote}
Yes that is the intent because most of it is initializing the DocumentStore and
the BlobStore which should not change. (As done with OAK-2016 and the existing
solution in DocumentNodeStoreService)
BTW did not get what is different from DocumentNodeStoreService. See below.
{code}
/**
* At runtime DocumentNodeStore only pickup modification of certain
properties
*/
@Modified
protected void modified(Map<String, ?> config){
versionGcMaxAgeInSecs = toLong(config.get(PROP_VER_GC_MAX_AGE),
DEFAULT_VER_GC_MAX_AGE);
blobGcMaxAgeInSecs = toLong(config.get(PROP_BLOB_GC_MAX_AGE),
DEFAULT_BLOB_GC_MAX_AGE);
}
{code}
> SegmentNodeStoreService should correctly handle modifications in the
> configuration
> ----------------------------------------------------------------------------------
>
> Key: OAK-2960
> URL: https://issues.apache.org/jira/browse/OAK-2960
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segmentmk
> Reporter: Francesco Mari
> Priority: Critical
> Fix For: 1.3.0
>
> Attachments: OAK-2960-01.patch
>
>
> The {{SegmentNodeStoreService}} component recently introduced an
> {{@Modified}} method that picks up changes in just one configuration property
> and ignores the rest.
> Some configuration properties, like {{customBlobStore}}, have a huge impact
> on the dynamic behaviour of the component. If the component fails to pick up
> these changes, its behaviour is just wrong.
> The {{@Modified}} method should be removed. It is safer to go through a
> complete deactivation and activation process.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
