[ 
https://issues.apache.org/jira/browse/OAK-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592980#comment-14592980
 ] 

Chetan Mehrotra commented on OAK-2986:
--------------------------------------

[~reschke] Looking at code I do not see any usage of RDBDataSourceFactory in 
production code (except oak-run). So would prefer if we do not add 
{{org.apache.juli.logging}} package in oak-core. Can it be moved to test. 
Basically we put it at some place where it can be used in oak-run and 
oak-core/tests. Also note that you can let the juli be included, logback has a 
way to route Java Logging to Logback logs

Further mark the dependency on {{tomcat-jdbc}} as optional

> RDB: switch to tomcat datasource implementation 
> ------------------------------------------------
>
>                 Key: OAK-2986
>                 URL: https://issues.apache.org/jira/browse/OAK-2986
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: rdbmk
>    Affects Versions: 1.2.2, 1.0.15, 1.3
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>             Fix For: 1.3.2
>
>         Attachments: OAK-2986.diff
>
>
> See <https://people.apache.org/~fhanik/jdbc-pool/jdbc-pool.html>.
> In addition, this is the datasource used in Slings datasource service, so 
> it's closer to what people will use in practice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to