[ 
https://issues.apache.org/jira/browse/OAK-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716490#comment-14716490
 ] 

Alex Parvulescu commented on OAK-3301:
--------------------------------------

I think the patch is good and I wanted to apply it, but then I ran into all the 
static variable from this test setup [0]. the patch will actually start mixing 
normal variables with static ones, so in this regard making the issue worse. is 
there a specific need for all of this staticness?

[0] 
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-upgrade/src/test/java/org/apache/jackrabbit/oak/upgrade/AbstractRepositoryUpgradeTest.java#L52

> AbstractRepositoryUpgrade leaks Repository instances
> ----------------------------------------------------
>
>                 Key: OAK-3301
>                 URL: https://issues.apache.org/jira/browse/OAK-3301
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: upgrade
>            Reporter: Robert Munteanu
>             Fix For: 1.4
>
>         Attachments: 
> 0001-OAK-3301-AbstractRepositoryUpgrade-leaks-Repository-.patch
>
>
> AbstractRepositoryUpgradeTest creates (JCR) repository instances but does not 
> close them ( actually creates a repository each time a session is requested ).
> This leads to out of memory errors when the process limit is hit on a machine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to