[ 
https://issues.apache.org/jira/browse/OAK-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14718498#comment-14718498
 ] 

Alex Parvulescu commented on OAK-3301:
--------------------------------------

bq. My conclusion is that this would require a larger change than I'm able to 
provide now, so my suggestion would be to apply the minimal change and fix the 
leak.

fair enough. I'm going to add a tiny change to the patch then, making 
targetRepository null will ensure that it will be recreated if needed. 
{code}
    @After
    public synchronized void shutdownTargetRepository() {
        if (targetRepository != null) {
            targetRepository.shutdown();
            targetRepository = null;
        }
    }
{code}

thoughts?

> AbstractRepositoryUpgrade leaks Repository instances
> ----------------------------------------------------
>
>                 Key: OAK-3301
>                 URL: https://issues.apache.org/jira/browse/OAK-3301
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: upgrade
>            Reporter: Robert Munteanu
>             Fix For: 1.4
>
>         Attachments: 
> 0001-OAK-3301-AbstractRepositoryUpgrade-leaks-Repository-.patch
>
>
> AbstractRepositoryUpgradeTest creates (JCR) repository instances but does not 
> close them ( actually creates a repository each time a session is requested ).
> This leads to out of memory errors when the process limit is hit on a machine.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to