[ 
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743057#comment-14743057
 ] 

Marcel Reutegger commented on OAK-3390:
---------------------------------------

I agree with Stefan. We are talking about as single instanceof we would like to 
get rid of. As mentioned before my preference is to move this factory method to 
a place where we know what kind of backend store is used. This is currently the 
DocumentMK.Builder, but in the long run we should probably split it up into a 
generic Builder and introduce two new builders: one for MongoDB and another one 
for RDB.

> Avoid instanceof check in DocumentNodeStore
> -------------------------------------------
>
>                 Key: OAK-3390
>                 URL: https://issues.apache.org/jira/browse/OAK-3390
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core, mongomk
>    Affects Versions: 1.3.4
>            Reporter: Marcel Reutegger
>             Fix For: 1.3.7
>
>
> The instanceof MongoDocumentStore check does not work anymore when the store 
> is wrapped with e.g. the LeaseCheckDocumentStoreWrapper.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to