[
https://issues.apache.org/jira/browse/OAK-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14744991#comment-14744991
]
Marcel Reutegger commented on OAK-3390:
---------------------------------------
This issue is specifically about the instanceof check in DocumentNodeStore
which was broken because of the wrapper classes that may be present. I agree,
the current fix is not the final solution, but it is a first step. As mentioned
before, I think the Builder class should be split into backend specific
implementations. That way the MongoDB builder implementation would override the
factory method without the need to perform an instanceof check. It already
knows it created a MongoDocumentStore.
For the LastRevRecoveryAgent I created OAK-3405.
> Avoid instanceof check in DocumentNodeStore
> -------------------------------------------
>
> Key: OAK-3390
> URL: https://issues.apache.org/jira/browse/OAK-3390
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core, mongomk
> Affects Versions: 1.3.4
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Fix For: 1.3.7
>
>
> The instanceof MongoDocumentStore check does not work anymore when the store
> is wrapped with e.g. the LeaseCheckDocumentStoreWrapper.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
