[ 
https://issues.apache.org/jira/browse/OAK-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998551#comment-14998551
 ] 

Alex Parvulescu commented on OAK-3612:
--------------------------------------

bq. cache of the SegmentWriter 
(org.apache.jackrabbit.oak.plugins.segment.SegmentWriter#records) is not 
cleared before the cleanup phase
it depends, we already clear the record cache on a successful compaction run 
[0], so this would only apply for the cases where compaction was skipped so I'm 
not exactly sure how much more efficient this will make the cleanup phase. any 
numbers to back this up?



[0] 
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/FileStore.java#L1088

> The string/template cache of the SegmentWriter should be cleared before 
> cleanup
> -------------------------------------------------------------------------------
>
>                 Key: OAK-3612
>                 URL: https://issues.apache.org/jira/browse/OAK-3612
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segmentmk
>            Reporter: Francesco Mari
>         Attachments: OAK-3612-01.patch
>
>
> The string/template cache of the SegmentWriter 
> (org.apache.jackrabbit.oak.plugins.segment.SegmentWriter#records) is not 
> cleared before the cleanup phase. This might maintain in-memory references to 
> segments, thus preventing them to be cleaned up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to