[
https://issues.apache.org/jira/browse/OAK-3612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006499#comment-15006499
]
Francesco Mari commented on OAK-3612:
-------------------------------------
I like your solution because it prevents me to make a change in oak-core, but
on the other hand I think that it would be more correct to place that change
where I initially proposed.
I think that the {{SegmentTracker}} should be responsible for the management of
the {{SegmentWriter}} it owns. {{SegmentTracker#clearCache}} looks like a
natural hook to make sure that every piece of cache directly or indirectly
maintained by the {{SegmentTracker}} is cleared.
Moreover, the reference held by the {{SegmentWriter}} looks like a general
problem of the Segment Store, and not a specific problem of the Standby Store.
Thus, it would probably make more sense to make the fix in oak-core.
> The string/template cache of the SegmentWriter should be cleared before
> cleanup
> -------------------------------------------------------------------------------
>
> Key: OAK-3612
> URL: https://issues.apache.org/jira/browse/OAK-3612
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segmentmk
> Reporter: Francesco Mari
> Fix For: 1.4
>
> Attachments: OAK-3612-01.patch
>
>
> The string/template cache of the SegmentWriter
> (org.apache.jackrabbit.oak.plugins.segment.SegmentWriter#records) is not
> cleared before the cleanup phase. This might maintain in-memory references to
> segments, thus preventing them to be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
