[ 
https://issues.apache.org/jira/browse/OAK-3529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048254#comment-15048254
 ] 

Marcel Reutegger commented on OAK-3529:
---------------------------------------

The DocumentNodeStore part looks OK.

The JavaDoc for getInstanceId() also mentions "It may be the same as a cluster 
id.". What exactly is a cluster id? I think it would be good to add a reference 
to the JavaDoc that points to the definition.

I'm also not too happy with the method on the builders. It is undefined when 
the methods return a non-null value. This makes it impossible to use reliably.

> NodeStore API should expose an Instance ID
> ------------------------------------------
>
>                 Key: OAK-3529
>                 URL: https://issues.apache.org/jira/browse/OAK-3529
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Davide Giannella
>            Assignee: Davide Giannella
>             Fix For: 1.4
>
>         Attachments: OAK-3529-1.patch, OAK-3529-2.patch, OAK-3529-3.patch
>
>
> For better leveraging cluster oriented algorithm: discovery, atomic
> operations; it would be very helpful if the NodeStore could expose a
> unique instance id.
> This can be the same as a cluster ID.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to