[
https://issues.apache.org/jira/browse/OAK-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121129#comment-15121129
]
Marcel Reutegger commented on OAK-3066:
---------------------------------------
Instead of exposing the two types of cache maps I would rather try to hide it.
AFAICS the methods nodeDocsAsMap() and previousDocsAsMap() are only used in the
invalidate calls and only the keys are needed. Why not create a single method
that gives you all the keys?
Similarly I would not create explicit methods for the two types of stats, but
rather change the return type of the existing method to return an
{{Iterable<CacheStats>}}.
You changed two constants in DocumentMKBuilder: {{DEFAULT_CACHE_SEGMENT_COUNT}}
and {{DEFAULT_CACHE_STACK_MOVE_DISTANCE}}. I think those are unrelated to the
cache distribution. I would not reduce the share of other explicitly controlled
caches, but rather let the builder reduce the remaining share of the document
cache automatically.
[~tmueller], is it possible to invalidate or update a cache entry of a
persistent cache?
> Persistent cache for previous documents
> ---------------------------------------
>
> Key: OAK-3066
> URL: https://issues.apache.org/jira/browse/OAK-3066
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, mongomk
> Reporter: Marcel Reutegger
> Assignee: Vikas Saurabh
> Priority: Blocker
> Labels: performance
> Fix For: 1.4, 1.3.15
>
> Attachments: OAK-3066.take1.patch, OAK-3066.wip.patch
>
>
> Previous (aka split) documents contain old revisions and are immutable
> documents. Those documents should go into the persistent cache to reduce
> calls to the underlying DocumentStore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
