[ 
https://issues.apache.org/jira/browse/OAK-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245817#comment-15245817
 ] 

Alexander Klimetschek commented on OAK-4048:
--------------------------------------------

I think you missed something - the missing null check is in the code itself. It 
does not make sense that it returns all users, including locals that have 
nothing to do with the external identity provider. [~tripod] actually asked me 
to create this issue :)

> [regression] SyncHandler.listIdentities() returns all users, not only 
> external ones
> -----------------------------------------------------------------------------------
>
>                 Key: OAK-4048
>                 URL: https://issues.apache.org/jira/browse/OAK-4048
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: auth-external
>            Reporter: Alexander Klimetschek
>         Attachments: OAK-4048.patch
>
>
> OAK-3508 accidentally introduced a regression in 
> https://github.com/apache/jackrabbit-oak/commit/cc78f6fdd122d1c9f200b43fc2b9536518ea996b#diff-490ff25c104d019ee25f92b2b8bdbabd
> If {{getIdentityRef(auth)}} returns null, {{createSyncedIdentity}} needs to 
> return null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to