[ 
https://issues.apache.org/jira/browse/OAK-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246241#comment-15246241
 ] 

angela commented on OAK-4048:
-----------------------------

It might well be that I miss something (in fact I miss a lot of things ;-)). 
Afaik this issue was about {{SyncHandler.listIdentities()}} and not about 
having or not having a null-value.

[~tripod], may I kindly ask you to verify if this is really a regression or 
not? When we were in Basel you told me that you introduced the change for some 
particular reason (hotfix whatsoever) and that it's not a regression... what 
way it is now?

> [regression] SyncHandler.listIdentities() returns all users, not only 
> external ones
> -----------------------------------------------------------------------------------
>
>                 Key: OAK-4048
>                 URL: https://issues.apache.org/jira/browse/OAK-4048
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: auth-external
>            Reporter: Alexander Klimetschek
>         Attachments: OAK-4048.patch
>
>
> OAK-3508 accidentally introduced a regression in 
> https://github.com/apache/jackrabbit-oak/commit/cc78f6fdd122d1c9f200b43fc2b9536518ea996b#diff-490ff25c104d019ee25f92b2b8bdbabd
> If {{getIdentityRef(auth)}} returns null, {{createSyncedIdentity}} needs to 
> return null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to