[
https://issues.apache.org/jira/browse/OAK-4220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
angela resolved OAK-4220.
-------------------------
Resolution: Fixed
Fix Version/s: 1.5.2
Committed revision 1740334.
[~tripod], i case you spot an issue with the fix please reopen. thanks.
> ExternalLoginModuleFactoryTest should extend from ExternalLoginModuleTestBase
> -----------------------------------------------------------------------------
>
> Key: OAK-4220
> URL: https://issues.apache.org/jira/browse/OAK-4220
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
> Reporter: angela
> Assignee: angela
> Priority: Minor
> Fix For: 1.5.2
>
> Attachments: OAK-4220.patch
>
>
> Looking at {{ExternalLoginModuleFactoryTest}} I get the impression that it
> could extend from {{ExternalLoginModuleTestBase}} which would simplify the
> test and remove quite some code duplication.
> The test class comes with the following comment:
> {quote}
> /**
> * This test uses quite a bit of logic from ExternalLoginModuleTestBase
> * As we need to create very specific scenario it would be easier to control
> * the whole scenario
> */
> {quote}
> I don't know which specific scenario the comment is referring to but IMHO it
> would be sufficient to leave the following specialized implementation of
> {{withEditors(Oak)}} as the rest of the test-setup seems effectively
> identical to the one provided by the test-base.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
